Accept a beginless range of values for a bare Array type - #2992
Merged
Merged
Conversation
ericproulx
force-pushed
the
fix/array-values-beginless-range
branch
from
September 23, 2026 06:51
efe42dd to
e4aa1a0
Compare
Danger ReportNo issues found. |
dblock
approved these changes
Sep 23, 2026
`requires :a, type: Array, values: ..5` raised `RangeError: cannot get the first element of beginless range` while the params were defined: `ValidationsSpec#guess_coerce_type` guessed the member type from `values.first`, which a beginless Range cannot answer. A Range now gives the class of its begin, or of its end when it has no begin. The incompatible-values check that follows still runs against that guess. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ericproulx
force-pushed
the
fix/array-values-beginless-range
branch
from
September 23, 2026 15:05
e4aa1a0 to
5555ff8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every release back to 2.1.3 raises this when the params are defined. For a bare
type: Array,ValidationsSpec#guess_coerce_typeguesses the member type thatvalues:implies, so that the incompatible-values check can compare them. It askedvalues.first, which a beginless Range cannot answer. An endless Range (1..) was fine, andtype: [Integer]never reaches the guess.A Range now gives the class of its
begin, or of itsendwhen it has no begin. Specs cover a beginless and an endless range, plus a beginless range whoseexcept_values:do not match the guessed type, which still raisesIncompatibleOptionValues. Both beginless examples fail on master with theRangeError.Found while covering the empty-list branch of the same line (#2983).
🤖 Generated with Claude Code